Repository navigation
perf: populate the Sym.simp grind normalization theorems at attribute time - #15725
Open
leodemoura wants to merge 1 commit into
Open
leodemoura wants to merge 1 commit into
leodemoura wants to merge 1 commit into
Conversation
…bute time This PR removes the rebuild of the `Sym.simp` normalization theorem set on every pattern normalization in `grind`. With `backward.grind.normalizer := false`, every `[grind]` attribute application and every theorem referenced by `instantiate`/`finish` paid a full conversion of the `[grind norm]` set (`grind_ite_trace` timed out). The `Sym.simp` theorems now live in their own environment extension, `normSymExt`, populated by the `[grind norm]`/`[grind unfold]` attributes together with `normExt`; the normalizer only reads the extension state. Requires a stage0 update. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
leodemoura
enabled auto-merge
October 16, 2026 03:16
github-actions
Bot
added
the
toolchain-available
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the rebuild of the
Sym.simpnormalization theorem set on every pattern normalization ingrind. Withbackward.grind.normalizer := false, every[grind]attribute application and every theorem referenced byinstantiate/finishpaid a full conversion of the[grind norm]set (grind_ite_tracetimed out).The
Sym.simptheorems now live in their own environment extension,normSymExt, populated by the[grind norm]/[grind unfold]attributes together withnormExt; the normalizer only reads the extension state. Requires a stage0 update.🤖 Generated with Claude Code