Skip to content

perf: lake: read the build store without taking its ref #15712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zeldovich wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −3
Draft

perf: lake: read the build store without taking its ref #15712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/lake/Lake/Util/StoreInsts.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,31 @@ public instance {cmp : κ → κ → Ordering} [Monad m] [Std.LawfulEqCmp cmp] :
fetch? k := modifyGet fun m => (m.get? k, m)
store k a := modify (·.insert k a)

/-
For the `StateRefT'` instances, a lookup must only *read* the ref (`get`), never `modifyGet` it.
`ST.Ref.modifyGet` takes the cell (atomic exchange with null) and holds it for the whole tree search,
so every fetch of every build thread would be serialized through one spinlock. A read of a persistent
map needs no exclusion: `get` holds the cell only long enough to bump a reference count. Only `store`
(an insert) needs to take the cell.
-/
public instance {cmp : κ → κ → Ordering} [MonadLiftT (ST ω) m] [Monad m] [Std.LawfulEqCmp cmp] : MonadDStore κ β (StateRefT' ω (Std.DTreeMap κ β cmp) m) where
fetch? k := modifyGet fun m => (m.get? k, m)
fetch? k := (·.get? k) <$> get
store k a := modify (·.insert k a)

public instance [Monad m] : MonadStore κ α (StateT (RBArray κ α cmp) m) where
fetch? k := modifyGet fun m => (m.find? k, m)
store k a := modify (·.insert k a)

public instance [MonadLiftT (ST ω) m] [Monad m] : MonadStore κ α (StateRefT' ω (RBArray κ α cmp) m) where
fetch? k := modifyGet fun m => (m.find? k, m)
fetch? k := (·.find? k) <$> get
store k a := modify (·.insert k a)

public instance [Monad m] : MonadStore Name α (StateT (NameMap α) m) where
fetch? k := modifyGet fun m => (m.find? k, m)
store k a := modify (·.insert k a)

public instance [MonadLiftT (ST ω) m] [Monad m] : MonadStore Name α (StateRefT' ω (NameMap α) m) where
fetch? k := modifyGet fun m => (m.find? k, m)
fetch? k := (·.find? k) <$> get
store k a := modify (·.insert k a)

public instance [MonadDStore κ β m] [t : FamilyOut β k α] : MonadStore1Of k α m where
Expand Down
Loading