refactor: eliminate simp +instances uses related to iterators/ranges/slices#12304
Draft
datokrat wants to merge 10 commits intosimp_no_instfrom
Draft
refactor: eliminate simp +instances uses related to iterators/ranges/slices#12304datokrat wants to merge 10 commits intosimp_no_instfrom
simp +instances uses related to iterators/ranges/slices#12304datokrat wants to merge 10 commits intosimp_no_instfrom
Conversation
This PR ensures `simp` does not "simplify" instances by default. The old behavior can be retrieved by using `simp +instances`. This PR is similar to #12195, but for `dsimp`. The backward compatibility flag for `dsimp` also deactivates this new feature. ``` set_option backward.dsimp.instances true ``` Applying `simp` (and `dsimp`) to instances creates non-standard instances, and this creates all sorts of problems in Mathlib.
Contributor
Author
|
!radar |
|
Benchmark results for 17089f2 against fe09431 are in! @datokrat
No significant changes detected. |
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
leodemoura
force-pushed
the
simp_no_inst
branch
from
d6bd7a1 to
d32d11c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suitably replaces all
simp +instancesusages related to iterators, ranges and slices.