-
Notifications
You must be signed in to change notification settings - Fork 733
feat: add BitVec.signExtend_extractLsb_setWidth theorem #11943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
osmanyasar05
wants to merge
9
commits into
leanprover:master
Choose a base branch
from
opencompl:sshiftRight_width_lsb
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 8, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 8, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jan 8, 2026
Collaborator
|
Reference manual CI status:
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 8, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 8, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jan 8, 2026
Collaborator
|
Mathlib CI status (docs):
|
Co-authored-by: Tobias Grosser <github@grosser.es>
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 9, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 9, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jan 9, 2026
Author
|
changelog-library |
bollu
approved these changes
Jan 9, 2026
Contributor
bollu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! It took me a moment's thinking to see why this is true, so a comment would be appreciated :)
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 9, 2026
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 9, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-manual
CI has verified that the Lean Language Reference builds against this PR
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-library
Library
mathlib4-nightly-available
A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the theorem
BitVec.sshiftRight_eq_setWidth_extractLsb_signExtendtheorem, provingx.sshiftRight nis equivalent to first sign-extendingx, extracting the appropriate least significant bits, and then setting the width back tow.