Repository navigation
refactor: remove the embedded MCP self-check - #324
Merged
Merged
Conversation
This PR runs the MCP discovery regression from independent application payloads so macOS can locate their private shared libraries when Lake restores a hard-linked executable. Discovery still has to succeed with the installation manifest missing. - Exercise both fresh and cache-linked frontend inputs without modifying build outputs or shared cache entries. - Check that copied executables have independent inodes and preserve the source and cache bytes.
Name the simulated cache-linked input explicitly and include paths and link counts in inode assertion failures. Update the test guidance to describe the missing installation and rejected flags, with coverage details in one place.
Let fake servers terminate with their fixture lifetime instead of signalling PIDs after they have been reaped. Require the existing typed missing-file error and modern result envelope, with negative fixtures for both checks.
ejgallego
force-pushed
the
codex/mcp-self-check-removal-final-20261020
branch
from
October 21, 2026 08:19
994119c to
09330df
Compare
Base automatically changed from
codex/bt068-darwin-cache-executables-20261020
to
main
October 21, 2026 10:05
ejgallego
marked this pull request as ready for review
October 21, 2026 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
lean-beam-mcp --self-checkand its embedded client and process supervisor. Installed and native stdio checks use the shared external MCP test harness. Setup verification useslean_syncfrom the configured client, exercising the actual client connection.