Repository navigation
fix: align speculative elaboration with its input text - #316
Merged
Merged
Conversation
Give parsed tactic and command probes their own matching source map and file name on every execution, including handle continuations. Preserve command continuation diagnostics after Lean resets its per-command message log. Check typed suggestion ranges, UTF-8 boundaries, handle branches and unchanged document state for ASCII and multibyte input.
ejgallego
marked this pull request as ready for review
October 20, 2026 14:24
Document probe source ownership, fresh continuation context, isolated state and artifact reset boundaries beside the implementation. Link the suggestion regression assertions from the testing guide. [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes suggestion-producing tactics such as
exact?during speculative execution by giving elaboration the same source text and file name as the parser. Each tactic or command handle continuation receives a fresh input context, so Lean interprets suggestion offsets against that probe rather than an empty or unrelated file map.