Skip to content

perf(RingTheory/Ideal/Quotient/Defs): clean up Ring instances again#38187

Open
JovanGerb wants to merge 5 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-Ideal-Quotient-Ring
Open

perf(RingTheory/Ideal/Quotient/Defs): clean up Ring instances again#38187
JovanGerb wants to merge 5 commits intoleanprover-community:masterfrom
JovanGerb:Jovan-Ideal-Quotient-Ring

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

I think I didn't do the instances right last time, and this version should be faster.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

PR summary 82df34056b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance {R} [CommRing R] (I : Ideal R) : CommSemiring (R ⧸ I)
+ instance {R} [CommRing R] (I : Ideal R) : Semiring (R ⧸ I) := semiring I
- commSemiring

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Apr 17, 2026
@JovanGerb
Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 17, 2026

Benchmark results for c360e74 against 82df340 are in. There are significant results. @JovanGerb

  • 🟥 main exited with code 1

No significant changes detected.

@JovanGerb
Copy link
Copy Markdown
Contributor Author

!bench

@JovanGerb JovanGerb closed this Apr 17, 2026
@JovanGerb JovanGerb reopened this Apr 17, 2026
@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 17, 2026

Benchmark results for aefc030 against 82df340 are in. No significant results found. @JovanGerb

  • build//instructions: -822.1M (-0.00%)

Small changes (2✅)

  • build/module/Mathlib.RingTheory.QuasiFinite.Polynomial//instructions: -785.1M (-1.87%)
  • build/module/Mathlib.RingTheory.Smooth.NoetherianDescent//instructions: -3.3G (-3.49%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants