Skip to content

chore(RingTheory/Localization): mirror tensor product compatibilities and golf#38177

Open
chrisflav wants to merge 2 commits intoleanprover-community:masterfrom
chrisflav:localization-isos-golf-fix
Open

chore(RingTheory/Localization): mirror tensor product compatibilities and golf#38177
chrisflav wants to merge 2 commits intoleanprover-community:masterfrom
chrisflav:localization-isos-golf-fix

Conversation

@chrisflav
Copy link
Copy Markdown
Member

We add a mirrored version of IsLocalization.tensorProduct_tensorProduct and some related isomorphisms. We use this to golf the proof of RingHom.locally_isStableUnderBaseChange.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

PR summary 718d4e20c0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsLocalization.Away.tensorProductEquivTMulRight
+ IsLocalization.Away.tensorProductEquivTMulRight_tmul
+ IsLocalization.tensorProductEquivOfMapIncludeRight
+ IsLocalization.tensorProductEquivOfMapIncludeRight_tmul
+ IsLocalization.tensorProduct_tensorProduct_right
+ IsStableUnderBaseChange.tensorProduct
+ Locally.span_eq_top
+ isScalarTower_localizationAlgebra
+ locally_iff_span_eq_top
- instance : IsScalarTower R (Localization M) (Localization (Algebra.algebraMapSubmonoid S M))

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
6511 1 backward.isDefEq.respectTransparency

Current commit 9bd9eabba9
Reference commit 718d4e20c0

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants