Skip to content

chore(GroupTheory/Finiteness): make Subgroup.FG a class#38169

Open
tb65536 wants to merge 3 commits intoleanprover-community:masterfrom
tb65536:tb_fgcl
Open

chore(GroupTheory/Finiteness): make Subgroup.FG a class#38169
tb65536 wants to merge 3 commits intoleanprover-community:masterfrom
tb65536:tb_fgcl

Conversation

@tb65536
Copy link
Copy Markdown
Contributor

@tb65536 tb65536 commented Apr 17, 2026

This PR refactors Subgroup.FG to be a class to match Group.FG.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) t-group-theory Group theory labels Apr 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

PR summary 96c2df6e3d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ AddSubgroup.FG
+ AddSubmonoid.FG
+ fg_of_finiteIndex
+ instance (H : Subgroup G) [H.FG] : Group.FG H
+ instance : (_root_.commutator G).FG := by
- instance : Group.FG (_root_.commutator G) := by

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) t-group-theory Group theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants