[Merged by Bors] - refactor: Avoid Rat internals in the definition of Field
#11639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soon, there will be `NNRat` analogs of the `Rat` fields in the definition of `Field`. `NNRat` is less nicely a structure than `Rat`, hence there is a need to reduce the dependency of `Field` on the internals of `Rat`. This PR achieves this by restating `Field.ratCast_mk'` in terms of `Rat.num`, `Rat.den`. This requires fixing a few downstream instances. Reduce the diff of #11203.
YaelDillies
added
awaiting-review
t-algebra
12 tasks
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
Member
|
bors merge |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
Contributor
|
Canceled. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
Collaborator
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2024
Soon, there will be `NNRat` analogs of the `Rat` fields in the definition of `Field`. `NNRat` is less nicely a structure than `Rat`, hence there is a need to reduce the dependency of `Field` on the internals of `Rat`. This PR achieves this by restating `Field.ratCast_mk'` in terms of `Rat.num`, `Rat.den`. This requires fixing a few downstream instances. Reduce the diff of #11203. Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Rat internals in the definition of FieldRat internals in the definition of Field
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
Soon, there will be `NNRat` analogs of the `Rat` fields in the definition of `Field`. `NNRat` is less nicely a structure than `Rat`, hence there is a need to reduce the dependency of `Field` on the internals of `Rat`. This PR achieves this by restating `Field.ratCast_mk'` in terms of `Rat.num`, `Rat.den`. This requires fixing a few downstream instances. Reduce the diff of #11203. Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Soon, there will be `NNRat` analogs of the `Rat` fields in the definition of `Field`. `NNRat` is less nicely a structure than `Rat`, hence there is a need to reduce the dependency of `Field` on the internals of `Rat`. This PR achieves this by restating `Field.ratCast_mk'` in terms of `Rat.num`, `Rat.den`. This requires fixing a few downstream instances. Reduce the diff of #11203. Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Soon, there will be `NNRat` analogs of the `Rat` fields in the definition of `Field`. `NNRat` is less nicely a structure than `Rat`, hence there is a need to reduce the dependency of `Field` on the internals of `Rat`. This PR achieves this by restating `Field.ratCast_mk'` in terms of `Rat.num`, `Rat.den`. This requires fixing a few downstream instances. Reduce the diff of #11203. Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Soon, there will be `NNRat` analogs of the `Rat` fields in the definition of `Field`. `NNRat` is less nicely a structure than `Rat`, hence there is a need to reduce the dependency of `Field` on the internals of `Rat`. This PR achieves this by restating `Field.ratCast_mk'` in terms of `Rat.num`, `Rat.den`. This requires fixing a few downstream instances. Reduce the diff of #11203. Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soon, there will be
NNRatanalogs of theRatfields in the definition ofField.NNRatis less nicely a structure thanRat, hence there is a need to reduce the dependency ofFieldon the internals ofRat.This PR achieves this by restating
Field.ratCast_mk'in terms ofRat.num,Rat.den. This requires fixing a few downstream instances.Reduce the diff of #11203.