[Merged by Bors] - chore(Field/InjSurj): Tidy #11480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the diff of #11203
YaelDillies
added
awaiting-review
t-algebra
12 tasks
Ruben-VandeVelde
approved these changes
Mar 18, 2024
Mathlib/Algebra/Field/Basic.lean
Outdated
| (neg : ∀ x, f (-x) = -f x) (sub : ∀ x y, f (x - y) = f x - f y) (inv : ∀ x, f x⁻¹ = (f x)⁻¹) | ||
| (div : ∀ x y, f (x / y) = f x / f y) | ||
| (nsmul : ∀ (x) (n : ℕ), f (n • x) = n • f x) | ||
| (zsmul : ∀ (x) (n : ℤ), f (n • x) = n • f x) (qsmul : ∀ (q : ℚ) (x), f (q • x) = q • f x) |
Collaborator
There was a problem hiding this comment.
Did you intentionally change the order of arguments to qsmul to no longer match nsmul and zsmul?
Collaborator
Author
There was a problem hiding this comment.
Yes, this is so that lemmas about the coercion qsmul can be used without shuffling their arguments.
eric-wieser
reviewed
Mar 18, 2024
eric-wieser
reviewed
Mar 18, 2024
Member
There was a problem hiding this comment.
Please add a comment to the docstring of this file noting the rationale for the inconsistent ordering of the binders in the nsmul and zsmul arguments.
eric-wieser
reviewed
Mar 18, 2024
eric-wieser
reviewed
Mar 18, 2024
eric-wieser
reviewed
Mar 18, 2024
eric-wieser
reviewed
Mar 18, 2024
eric-wieser
added
awaiting-author
YaelDillies
added
awaiting-review
and removed
awaiting-author
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
fpvandoorn
approved these changes
Apr 5, 2024
| -- Porting Note: Commented | ||
| -- attribute [local semireducible] locallyRingedSpaceAdjunction ΓSpec.adjunction | ||
|
|
||
| set_option maxHeartbeats 400000 in |
Member
There was a problem hiding this comment.
any idea what changed here / how to make this better / avoid the convert?
Collaborator
Author
There was a problem hiding this comment.
The proof uses 200959 heartbeats and basically the same on master so I suspect this is just noise
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
Collaborator
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
Among other things, change the `nsmul`, `zsmul`, `qsmul` fields to have `n`/`q` come before `x`, because this matches the lemmas we want to write about them. It would be preferrable to perform the same changes to the `AddMonoid`/`AddGroup`-like typeclasses, but this is impossible with the current `to_additive` framework, so instead I have inserted some `Function.swap` at the interface between `AddMonoid`/`AddGroup` and `Ring`/`Field`. Reduce the diff of #11203
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
Among other things, change the `nsmul`, `zsmul`, `qsmul` fields to have `n`/`q` come before `x`, because this matches the lemmas we want to write about them. It would be preferrable to perform the same changes to the `AddMonoid`/`AddGroup`-like typeclasses, but this is impossible with the current `to_additive` framework, so instead I have inserted some `Function.swap` at the interface between `AddMonoid`/`AddGroup` and `Ring`/`Field`. Reduce the diff of #11203
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Among other things, change the `nsmul`, `zsmul`, `qsmul` fields to have `n`/`q` come before `x`, because this matches the lemmas we want to write about them. It would be preferrable to perform the same changes to the `AddMonoid`/`AddGroup`-like typeclasses, but this is impossible with the current `to_additive` framework, so instead I have inserted some `Function.swap` at the interface between `AddMonoid`/`AddGroup` and `Ring`/`Field`. Reduce the diff of #11203
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Among other things, change the `nsmul`, `zsmul`, `qsmul` fields to have `n`/`q` come before `x`, because this matches the lemmas we want to write about them. It would be preferrable to perform the same changes to the `AddMonoid`/`AddGroup`-like typeclasses, but this is impossible with the current `to_additive` framework, so instead I have inserted some `Function.swap` at the interface between `AddMonoid`/`AddGroup` and `Ring`/`Field`. Reduce the diff of #11203
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Among other things, change the `nsmul`, `zsmul`, `qsmul` fields to have `n`/`q` come before `x`, because this matches the lemmas we want to write about them. It would be preferrable to perform the same changes to the `AddMonoid`/`AddGroup`-like typeclasses, but this is impossible with the current `to_additive` framework, so instead I have inserted some `Function.swap` at the interface between `AddMonoid`/`AddGroup` and `Ring`/`Field`. Reduce the diff of #11203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other things, change the
nsmul,zsmul,qsmulfields to haven/qcome beforex, because this matches the lemmas we want to write about them. It would be preferrable to perform the same changes to theAddMonoid/AddGroup-like typeclasses, but this is impossible with the currentto_additiveframework, so instead I have inserted someFunction.swapat the interface betweenAddMonoid/AddGroupandRing/Field.Reduce the diff of #11203