[Merged by Bors] - chore: resolve "apply → induction" porting notes#11444
Closed
pitmonticone wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore: resolve "apply → induction" porting notes#11444pitmonticone wants to merge 2 commits intomasterfrom
apply → induction" porting notes#11444pitmonticone wants to merge 2 commits intomasterfrom
Conversation
pitmonticone
added
awaiting-review
easy
eric-wieser
reviewed
Mar 17, 2024
Mathlib/Data/Polynomial/Eval.lean
Outdated
| @[simp] | ||
| theorem eval_C_mul : (C a * p).eval x = a * p.eval x := by | ||
| -- Porting note: `apply` → `induction` | ||
| -- Porting note (#11443): `apply` → `induction` |
Member
There was a problem hiding this comment.
Let's just drop these comments, the new induction is better than apply anyway.
Member
Author
There was a problem hiding this comment.
Ok @eric-wieser, I'm going to remove all these porting notes, update the descriptions accordingly and eventually closing the associated issue.
Member
Author
|
@eric-wieser I've resolved the " |
pitmonticone
changed the title
apply → induction" porting notesapply → induction" porting notes
ghost
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2024
Resolves porting notes claiming "`apply` → `induction`" since the new `induction` is more idiomatic than `apply`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
apply → induction" porting notesapply → induction" porting notes
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Resolves porting notes claiming "`apply` → `induction`" since the new `induction` is more idiomatic than `apply`.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
Resolves porting notes claiming "`apply` → `induction`" since the new `induction` is more idiomatic than `apply`.
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
Resolves porting notes claiming "`apply` → `induction`" since the new `induction` is more idiomatic than `apply`.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Resolves porting notes claiming "`apply` → `induction`" since the new `induction` is more idiomatic than `apply`.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Resolves porting notes claiming "`apply` → `induction`" since the new `induction` is more idiomatic than `apply`.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Resolves porting notes claiming "`apply` → `induction`" since the new `induction` is more idiomatic than `apply`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves porting notes claiming "
apply→induction" since the newinductionis more idiomatic thanapply.