Skip to content

Comments

[Merged by Bors] - chore: classify todo porting notes#11216

Closed
pitmonticone wants to merge 5 commits intomasterfrom
pitmonticone/todo
Closed

[Merged by Bors] - chore: classify todo porting notes#11216
pitmonticone wants to merge 5 commits intomasterfrom
pitmonticone/todo

Conversation

@pitmonticone
Copy link
Member

Classifies by adding issue number #11215 to porting notes claiming "TODO".

@pitmonticone pitmonticone added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. labels Mar 7, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this now, with the understanding that we might need some subclassification at a later stage.

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 8, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 8, 2024
Classifies by adding issue number #11215 to porting notes claiming "TODO".
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: classify todo porting notes [Merged by Bors] - chore: classify todo porting notes Mar 8, 2024
@mathlib-bors mathlib-bors bot closed this Mar 8, 2024
@mathlib-bors mathlib-bors bot deleted the pitmonticone/todo branch March 8, 2024 09:17
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Classifies by adding issue number #11215 to porting notes claiming "TODO".
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Classifies by adding issue number #11215 to porting notes claiming "TODO".
utensil pushed a commit that referenced this pull request Mar 26, 2024
Classifies by adding issue number #11215 to porting notes claiming "TODO".
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
Classifies by adding issue number #11215 to porting notes claiming "TODO".
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Classifies by adding issue number #11215 to porting notes claiming "TODO".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants