Skip to content

Comments

[Merged by Bors] - chore: classify slow / slower porting notes#11084

Closed
pitmonticone wants to merge 1 commit intomasterfrom
pitmonticone/slow-slower
Closed

[Merged by Bors] - chore: classify slow / slower porting notes#11084
pitmonticone wants to merge 1 commit intomasterfrom
pitmonticone/slow-slower

Conversation

@pitmonticone
Copy link
Member

@pitmonticone pitmonticone commented Mar 1, 2024

Classifies by adding issue number #11083 to porting notes claiming anything semantically equivalent to:

  • "very slow; improve performance?"
  • "quite slow; improve performance?"
  • "`tactic" was slow"
  • "removed attribute because it caused extremely slow tactic"
  • "proof was rewritten, because it was too slow"
  • "doing this make things very slow"
  • "slower implementation"

@pitmonticone pitmonticone added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. labels Mar 1, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 1, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 1, 2024
Classifies by adding issue number #11083 to porting notes claiming anything semantically equivalent to: 

- "very **slow**; improve performance?"
- "quite **slow**; improve performance?"
- "`tactic" was **slow**"
- "removed `attribute` because it caused extremely **slow** `tactic`"
- "proof was rewritten, because it was too **slow**"
- "doing this make things very **slow**"
- "**slower** implementation"
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 1, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: classify slow / slower porting notes [Merged by Bors] - chore: classify slow / slower porting notes Mar 1, 2024
@mathlib-bors mathlib-bors bot closed this Mar 1, 2024
@mathlib-bors mathlib-bors bot deleted the pitmonticone/slow-slower branch March 1, 2024 15:31
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
Classifies by adding issue number #11083 to porting notes claiming anything semantically equivalent to: 

- "very **slow**; improve performance?"
- "quite **slow**; improve performance?"
- "`tactic" was **slow**"
- "removed `attribute` because it caused extremely **slow** `tactic`"
- "proof was rewritten, because it was too **slow**"
- "doing this make things very **slow**"
- "**slower** implementation"
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Classifies by adding issue number #11083 to porting notes claiming anything semantically equivalent to: 

- "very **slow**; improve performance?"
- "quite **slow**; improve performance?"
- "`tactic" was **slow**"
- "removed `attribute` because it caused extremely **slow** `tactic`"
- "proof was rewritten, because it was too **slow**"
- "doing this make things very **slow**"
- "**slower** implementation"
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Classifies by adding issue number #11083 to porting notes claiming anything semantically equivalent to: 

- "very **slow**; improve performance?"
- "quite **slow**; improve performance?"
- "`tactic" was **slow**"
- "removed `attribute` because it caused extremely **slow** `tactic`"
- "proof was rewritten, because it was too **slow**"
- "doing this make things very **slow**"
- "**slower** implementation"
utensil pushed a commit that referenced this pull request Mar 26, 2024
Classifies by adding issue number #11083 to porting notes claiming anything semantically equivalent to: 

- "very **slow**; improve performance?"
- "quite **slow**; improve performance?"
- "`tactic" was **slow**"
- "removed `attribute` because it caused extremely **slow** `tactic`"
- "proof was rewritten, because it was too **slow**"
- "doing this make things very **slow**"
- "**slower** implementation"
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
Classifies by adding issue number #11083 to porting notes claiming anything semantically equivalent to: 

- "very **slow**; improve performance?"
- "quite **slow**; improve performance?"
- "`tactic" was **slow**"
- "removed `attribute` because it caused extremely **slow** `tactic`"
- "proof was rewritten, because it was too **slow**"
- "doing this make things very **slow**"
- "**slower** implementation"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants