Skip to content

Comments

[Merged by Bors] - chore: classify broken proof was porting notes#11040

Closed
pitmonticone wants to merge 1 commit intomasterfrom
pitmonticone/broken-proof-was
Closed

[Merged by Bors] - chore: classify broken proof was porting notes#11040
pitmonticone wants to merge 1 commit intomasterfrom
pitmonticone/broken-proof-was

Conversation

@pitmonticone
Copy link
Member

Classifies by adding issue number #11039 to porting notes claiming:

broken proof was

@pitmonticone pitmonticone added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. labels Feb 28, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indicate on the issue #11039 that this is a bit of a "grab bag" collection: there will probably not be a single fix for all the instances.
For that reason, it might make sense to list all instances as examples on the issue page, which is feasible because there are only 13 of them.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Feb 28, 2024
@pitmonticone
Copy link
Member Author

@jcommelin Done!

@jcommelin jcommelin added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Feb 29, 2024
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 29, 2024
Classifies by adding issue number #11039 to porting notes claiming: 

> broken proof was
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 29, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: classify broken proof was porting notes [Merged by Bors] - chore: classify broken proof was porting notes Feb 29, 2024
@mathlib-bors mathlib-bors bot closed this Feb 29, 2024
@mathlib-bors mathlib-bors bot deleted the pitmonticone/broken-proof-was branch February 29, 2024 12:38
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
Classifies by adding issue number #11039 to porting notes claiming: 

> broken proof was
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Classifies by adding issue number #11039 to porting notes claiming: 

> broken proof was
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Classifies by adding issue number #11039 to porting notes claiming: 

> broken proof was
utensil pushed a commit that referenced this pull request Mar 26, 2024
Classifies by adding issue number #11039 to porting notes claiming: 

> broken proof was
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
Classifies by adding issue number #11039 to porting notes claiming: 

> broken proof was
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants