[Merged by Bors] - chore: classify avoid simpNF linter error porting notes#10760
Closed
pitmonticone wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore: classify avoid simpNF linter error porting notes#10760pitmonticone wants to merge 4 commits intomasterfrom
avoid simpNF linter error porting notes#10760pitmonticone wants to merge 4 commits intomasterfrom
Conversation
pitmonticone
added
awaiting-review
easy
Vierkantor
reviewed
Feb 20, 2024
Contributor
Vierkantor
left a comment
Vierkantor
left a comment
There was a problem hiding this comment.
I think these notes should be classified the same as #10619.
Vierkantor
added
awaiting-author
pitmonticone
commented
Feb 20, 2024
Vierkantor
approved these changes
Feb 20, 2024
Contributor
Vierkantor
left a comment
Vierkantor
left a comment
There was a problem hiding this comment.
Since that PR got approved, let's get this merged too!
bors r+
ghost
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Classifies by adding issue number (#10759) to porting notes claiming: > removed `@[simp]` to avoid a `simpNF` linter error.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
avoid simpNF linter error porting notesavoid simpNF linter error porting notes
thorimur
pushed a commit
that referenced
this pull request
Feb 24, 2024
Classifies by adding issue number (#10759) to porting notes claiming: > removed `@[simp]` to avoid a `simpNF` linter error.
thorimur
pushed a commit
that referenced
this pull request
Feb 26, 2024
Classifies by adding issue number (#10759) to porting notes claiming: > removed `@[simp]` to avoid a `simpNF` linter error.
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
Classifies by adding issue number (#10759) to porting notes claiming: > removed `@[simp]` to avoid a `simpNF` linter error.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Classifies by adding issue number (#10759) to porting notes claiming: > removed `@[simp]` to avoid a `simpNF` linter error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classifies by adding issue number (#10759) to porting notes claiming: