Skip to content

Comments

[Merged by Bors] - chore: classify was rw porting notes#10692

Closed
pitmonticone wants to merge 1 commit intomasterfrom
pitmonticone/was-rw
Closed

[Merged by Bors] - chore: classify was rw porting notes#10692
pitmonticone wants to merge 1 commit intomasterfrom
pitmonticone/was-rw

Conversation

@pitmonticone
Copy link
Member

Classifies by adding issue number (#10691) to porting notes claiming was rw.

@pitmonticone pitmonticone added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. labels Feb 18, 2024
@kbuzzard
Copy link
Member

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by kbuzzard.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Feb 20, 2024
@kbuzzard
Copy link
Member

Whilst I would prefer issues which covered hundreds of porting notes rather than just 8, several of the examples here are where rw has become erw and in my mind this indicates that something is wrong, so my feeling is that this is a good category even if it's a small one.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 20, 2024
@mattrobball
Copy link
Contributor

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 20, 2024

Already running a review

mathlib-bors bot pushed a commit that referenced this pull request Feb 20, 2024
Classifies by adding issue number (#10691) to porting notes claiming `was rw`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 20, 2024

Build failed (retrying...):

  • Build

mathlib-bors bot pushed a commit that referenced this pull request Feb 20, 2024
Classifies by adding issue number (#10691) to porting notes claiming `was rw`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 20, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 20, 2024
Classifies by adding issue number (#10691) to porting notes claiming `was rw`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: classify was rw porting notes [Merged by Bors] - chore: classify was rw porting notes Feb 20, 2024
@mathlib-bors mathlib-bors bot closed this Feb 20, 2024
@mathlib-bors mathlib-bors bot deleted the pitmonticone/was-rw branch February 20, 2024 23:51
thorimur pushed a commit that referenced this pull request Feb 24, 2024
Classifies by adding issue number (#10691) to porting notes claiming `was rw`.
thorimur pushed a commit that referenced this pull request Feb 26, 2024
Classifies by adding issue number (#10691) to porting notes claiming `was rw`.
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
Classifies by adding issue number (#10691) to porting notes claiming `was rw`.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Classifies by adding issue number (#10691) to porting notes claiming `was rw`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. porting-notes Mathlib3 to Mathlib4 porting notes. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants