Skip to content

[Merged by Bors] - chore: Fix some porting notes and make some defs computable again. #10062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: Fix some porting notes and make some defs computable again. #10062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions Mathlib/CategoryTheory/Monoidal/OfChosenFiniteProducts/Basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ which seems less often useful.

universe v u

noncomputable section

namespace CategoryTheory

Expand Down Expand Up @@ -190,16 +189,7 @@ def BinaryFan.associatorOfLimitCone (L : ∀ X Y : C, LimitCone (pair X Y)) (X Y
def BinaryFan.leftUnitor {X : C} {s : Cone (Functor.empty.{v} C)} (P : IsLimit s)
{t : BinaryFan s.pt X} (Q : IsLimit t) : t.pt ≅ X where
hom := t.snd
inv :=
Q.lift
(BinaryFan.mk
(P.lift
{ pt := X, π :=
-- Porting note: there is something fishy here:
-- `PEmpty.rec x x` should not even typecheck.
{ app := fun x => Discrete.rec (fun x => PEmpty.rec.{_, v+1} x x) x } })
(𝟙 X))
-- Porting note: this should be automatable:
inv := Q.lift <| BinaryFan.mk (P.lift ⟨_, fun x => x.as.elim, fun {x} => x.as.elim⟩) (𝟙 _)
hom_inv_id := by
apply Q.hom_ext
rintro ⟨⟨⟩⟩
Expand All @@ -214,15 +204,7 @@ def BinaryFan.leftUnitor {X : C} {s : Cone (Functor.empty.{v} C)} (P : IsLimit s
def BinaryFan.rightUnitor {X : C} {s : Cone (Functor.empty.{v} C)} (P : IsLimit s)
{t : BinaryFan X s.pt} (Q : IsLimit t) : t.pt ≅ X where
hom := t.fst
inv :=
Q.lift
(BinaryFan.mk (𝟙 X)
(P.lift
{ pt := X
π :=
-- Porting note: there is something fishy here:
-- `PEmpty.rec x x` should not even typecheck.
{ app := fun x => Discrete.rec (fun x => PEmpty.rec.{_, v+1} x x) x } }))
inv := Q.lift <| BinaryFan.mk (𝟙 _) <| P.lift ⟨_, fun x => x.as.elim, fun {x} => x.as.elim⟩
hom_inv_id := by
apply Q.hom_ext
rintro ⟨⟨⟩⟩
Expand Down