Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

feat(algebra/archimedean): add fractional parts of floor_rings#709

Merged
ChrisHughes24 merged 1 commit into
masterfrom
kmb_fract3
Feb 10, 2019
Merged

feat(algebra/archimedean): add fractional parts of floor_rings#709
ChrisHughes24 merged 1 commit into
masterfrom
kmb_fract3

Conversation

@kbuzzard

Copy link
Copy Markdown
Member

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list


This is a theory of fractional parts of reals and more general floor_rings, i.e. fract r := r - floor r.

Note that I've added another import, abel, to algebra/archimedean.lean; linarith imports ring but I can't use ring because a floor_ring is not necessarily commutative. Without this import I would have to directly prove something of the form a+(b+c)-(b-a)=c, that sort of thing, which I could do but didn't.

[This is the same as #703, where a little rebasing experiment of mine went wrong]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants