This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(algebra/*/opposite): Missing instances #18602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
This was referenced Mar 16, 2023
eric-wieser
reviewed
Mar 17, 2023
eric-wieser
reviewed
Mar 17, 2023
eric-wieser
added
awaiting-author
YaelDillies
added
awaiting-review
eric-wieser
approved these changes
Mar 17, 2023
Member
eric-wieser
left a comment
eric-wieser
left a comment
There was a problem hiding this comment.
bors merge
Thanks! I edited the description mention the defeq of rat.cast
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
A few missing instances about `nat.cast`/`int.cast`/`rat.cast` and `mul_opposite`/`add_opposite`. Also add the (weirdly) missing `add_comm_group_with_one → add_comm_monoid_with_one`. Finally, this changes the defeq of `rat.cast` on `mul_opposite` to be simpler.
|
Build failed: |
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
A few missing instances about `nat.cast`/`int.cast`/`rat.cast` and `mul_opposite`/`add_opposite`. Also add the (weirdly) missing `add_comm_group_with_one → add_comm_monoid_with_one`. Finally, this changes the defeq of `rat.cast` on `mul_opposite` to be simpler.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 24, 2023
Match leanprover-community/mathlib3#18602 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few missing instances about
nat.cast/int.cast/rat.castandmul_opposite/add_opposite.Also add the (weirdly) missing
add_comm_group_with_one → add_comm_monoid_with_one.Finally, this changes the defeq of
rat.castonmul_oppositeto be simpler.Match leanprover-community/mathlib4#2940