Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Conversation

@YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Mar 15, 2023

Rename pow_minus_two_nonneg to zpow_neg_two_nonneg and move it to algebra.order.field.power.


This might look like a inconsequential change on its own, but it allows me to unmangle the import tree to introduce nnrat.cast in #16554.

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Mar 15, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that bit0 is deprecated in Lean 4, can you add a zpow_neg_two_nonneg lemma with the original statement?

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 15, 2023
@YaelDillies YaelDillies changed the title chore(algebra/order/field/basic): Deduplicate pow_minus_two_nonneg chore(algebra/order/field/basic): Rename pow_minus_two_nonneg Mar 16, 2023
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 16, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@bors
Copy link

bors bot commented Mar 16, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 16, 2023
@eric-wieser eric-wieser added the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 16, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Mar 16, 2023
@eric-wieser
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 16, 2023
bors bot pushed a commit that referenced this pull request Mar 16, 2023
Rename `pow_minus_two_nonneg` to `zpow_neg_two_nonneg` and move it to `algebra.order.field.power`.
@eric-wieser
Copy link
Member

bors r-

(trying to get this in the same batch)

@bors
Copy link

bors bot commented Mar 16, 2023

Canceled.

@eric-wieser
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 16, 2023
Rename `pow_minus_two_nonneg` to `zpow_neg_two_nonneg` and move it to `algebra.order.field.power`.
@bors
Copy link

bors bot commented Mar 16, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/order/field/basic): Rename pow_minus_two_nonneg [Merged by Bors] - chore(algebra/order/field/basic): Rename pow_minus_two_nonneg Mar 16, 2023
@bors bors bot closed this Mar 16, 2023
@bors bors bot deleted the kill_pow_minus_two_nonneg branch March 16, 2023 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants