This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(algebra/ring/ulift): Split off and golf field instances #18590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
awaiting-review
This was referenced Mar 15, 2023
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
eric-wieser
reviewed
Mar 15, 2023
eric-wieser
added
the
awaiting-CI
eric-wieser
reviewed
Mar 16, 2023
Collaborator
Author
|
bors merge |
|
👎 Rejected by label |
YaelDillies
removed
the
awaiting-CI
Collaborator
Author
|
Just fixed the lint so it will go through. bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
Move field-like instances on `ulift` from `algebra.ring.ulift` to a new file `algebra.field.ulift`. Golf them by declaring the `has_nat_cast` and `has_int_cast` instances earlier.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 17, 2023
Match leanprover-community/mathlib3#18590 and leanprover-community/mathlib3#18596 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 17, 2023
Match leanprover-community/mathlib3#18590 and leanprover-community/mathlib3#18596 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move field-like instances on
uliftfromalgebra.ring.uliftto a new filealgebra.field.ulift. Golf them by declaring thehas_nat_castandhas_int_castinstances earlier.Match leanprover-community/mathlib4#2911