fix(frontends/lean/parser): start positions of trailing parser (NuD) nodes #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems unhappy with this test: lean/tests/lean/interactive/info.lean Lines 15 to 16 in cb0da9f which no longer produces |
eric-wieser
reviewed
Nov 18, 2022
| @@ -1425,14 +1425,15 @@ static pair<notation::transition, parse_table> const * get_non_skip(list<pair<no | |||
| expr parser::parse_notation(parse_table t, expr * left) { | |||
| check_system("parse_notation"); | |||
| lean_assert(curr() == token_kind::Keyword); | |||
| auto p = pos(); | |||
| auto cur_pos = pos(); | |||
| auto p = left ? expr_ast(*left).m_start : cur_pos; | |||
There was a problem hiding this comment.
I don't understand this change; I'm probably blind, but it appears that nothing uses p below any more?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed by @eric-wieser , the node for
notation[$]inwas covering only the span
$ trivialinstead ofid $ trivial, meaning that theidchild is outside of the span of its parent node. The fix is to take the start position from the start position of the first child instead of the current parser position when we parse a trailing node. (We also want to use this position for most other activities like constructing multiple expressions all with the same position due to notation expansion, but not for the error message when the parse is invalid.)