Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exceptions when saving oleans are not user-visible #750

Open
1 task done
collares opened this issue Jul 29, 2022 · 0 comments
Open
1 task done

exceptions when saving oleans are not user-visible #750

collares opened this issue Jul 29, 2022 · 0 comments

Comments

@collares
Copy link

collares commented Jul 29, 2022

Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:
    • Checked that your issue isn't already filed.
    • Reduced the issue to a self-contained, reproducible test case.

Description

The olean compilation process emits user-friendly messages for several failure scenarios, such as https://github.com/leanprover-community/lean/blob/v3.45.0/src/library/module_mgr.cpp#L128. However, the failure is not notified to the user. This includes heartbeat exception reporting, as in #749.

Steps to Reproduce

  1. Create an empty olean and remove write permissions
  2. Use lean --make to compile something that would overwrite the above file

Expected behavior: Non-zero exit code and a message

Actual behavior: No reported error

Reproduces how often: 100%

Versions

Lean (version 3.45.0, commit 22b09be, Release)

bors bot pushed a commit to leanprover-community/mathlib3 that referenced this issue Aug 31, 2022
We are currently experiencing timeouts when saving some oleans (leanprover-community/lean#749). Since Lean does not error out when deterministic timeouts happen during olean generation (leanprover-community/lean#750) and we already run Lean twice when compiling mathlib, Ben Toner suggested the following clever hack: Increase the timeout, but only on the second lean run. This effectively means anything that was reported as a timeout before is still reported as a timeout (by the first call), while olean generation gets more heartbeats.

Co-authored-by: Ben Toner <bentoner@bentoner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant