Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention of assumption in Advanced Addition Level 4 #74

Closed
RodneyMKay opened this issue Jul 7, 2024 · 4 comments
Closed

Mention of assumption in Advanced Addition Level 4 #74

RodneyMKay opened this issue Jul 7, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@RodneyMKay
Copy link

RodneyMKay commented Jul 7, 2024

In level 4/6 of the advanced addition world, the solution via induction uses the assumption tactic, which is not part of the course. This is not an issue per-se, but it's a bit confusing to someone (like myself), who has never seen this tactic. Might be worth it to explain what that's about in the comment or replacing both assumption with apply h.

Code reference:

If you tell me how you want it solved (whether that be an additional hint explaning assumption, replacing it with apply h or introducing assumption as a concept properly in some level), I'll gladly create a PR for it :)

PS: Thanks for creating such an awesome learning resource for lean!

@zetaraku
Copy link

zetaraku commented Aug 6, 2024

I encountered this confusion too and I think it was a mistake when simplifying the level. (See: a01eb1b)

I think it's better to fix it by replacing it with apply h.

The maintainer may be busy, so I recommend you open a PR to fix it.

@joneugster
Copy link
Collaborator

joneugster commented Aug 7, 2024

Sorry for the late reply! I think the NNG usually uses exact h in these situations instead of assumption. (but apply h is fine, too) If you want to make a PR that's very welcome, otherwise I will address this the next time I'll update the game on the author's behalf, which might still take a moment as there is another problem I haven't fully addressed yet

@zetaraku
Copy link

zetaraku commented Aug 8, 2024

Oh, it's exact h. My mistake. 😄

@joneugster joneugster added the documentation Improvements or additions to documentation label Aug 28, 2024
@RodneyMKay
Copy link
Author

Oh! I just started work on a PR, but seems like someone was ahead of me in #64. Gonna close this issue then, since it's solved. Thanks again :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants