[linux] fix on_window_show and on_window_hide signatures
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signals do not have an "event" argument: - https://docs.gtk.org/gtk3/vfunc.Widget.show.html - https://docs.gtk.org/gtk3/vfunc.Widget.hide.html It's important to have the correct signature to ensure that the user data pointer argument points to the correct memory address.
jpnurmi
changed the title
on_window_show and on_window_hide signatures
This was referenced Jan 4, 2023
obiwanzenobi
pushed a commit
to obiwanzenobi/window_manager
that referenced
this pull request
May 25, 2023
…#268) The signals do not have an "event" argument: - https://docs.gtk.org/gtk3/vfunc.Widget.show.html - https://docs.gtk.org/gtk3/vfunc.Widget.hide.html It's important to have the correct signature to ensure that the user data pointer argument points to the correct memory address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GtkWidget::show and GtkWidget::hide signals do not have any "event" argument. It's important to have the correct signature to ensure that the user data argument points to the correct memory address.