Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: make setTitleBarStyle() GTK/HDY/CSD/SSD compatible #249

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Linux: make setTitleBarStyle() GTK/HDY/CSD/SSD compatible #249

merged 2 commits into from
Dec 11, 2022

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Dec 7, 2022 •
edited
Loading

When it comes to hiding the window title bar, there are a few cases to consider.

  1. The default Flutter app template defaults to a server-side decorated window title on non-GNOME X11 desktops.
  2. Any desktop running on Wayland, and GNOME on X11, default to a client-side decorated GtkHeaderBar.
  3. Furthermore, the handy_window package, which is popular in Flutter-based Ubuntu apps, provides a more modern-looking HdyWindow with rounded bottom corners and the header bar replaced by HdyHeaderBar.

This PR ensures that setTitleBarStyle() works in all these three cases on Linux.

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Dec 7, 2022

GTK & SSD

gtk_ssd.webm

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Dec 7, 2022

GTK & CSD

gtk_csd.webm

@jpnurmi
Copy link
Contributor Author

jpnurmi commented Dec 7, 2022

HDY & CSD

hdy_csd.webm

@jpnurmi jpnurmi mentioned this pull request Dec 7, 2022
Merged
@lijy91
Copy link
Member

lijy91 commented Dec 11, 2022

LGTM

@lijy91 lijy91 merged commit 8ae11b8 into leanflutter:main Dec 11, 2022
@jpnurmi jpnurmi deleted the linux-title-bar-style branch December 11, 2022 09:05
@jpnurmi
Copy link
Contributor Author

jpnurmi commented Dec 28, 2022

@lijy91 any chance to have a new version published?

obiwanzenobi pushed a commit to obiwanzenobi/window_manager that referenced this pull request May 25, 2023
@jpnurmi @obiwanzenobi
Linux: make setTitleBarStyle() GTK/HDY/CSD/SSD compatible (leanflut…
0029197 
…ter#249)

* Linux: make setTitleBarStyle() GTK/HDY/CSD/SSD compatible

* Fix memory leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpnurmi @lijy91