frameless is broken after #367

[aexei]

I think since merging Better fullscreen implementation the frameless feature is not working anymore.

Can someone confirm that?

[damywise]

Can you try calling setTitleBarStyle(TitleBarStyle.hidden) first and then setAsFrameless() and see if it works now?

If not, can you please provide more context and details to better address the issue:

1. What exactly is not working? Please specify symptoms or behaviors.
2. Which version of Windows are you experiencing the issue on?
3. Please provide steps to reproduce the issue.
4. Could you provide a minimal code snippet that reproduces the issue?

[damywise]

If it works, this might be the problem https://github.com/leanflutter/window_manager/blob/36f34eadbe0a7fe0c589052f537ef1bcb502835c/windows/window_manager_plugin.cpp#L115C45-L115C89

[lijy91]

@damywise Can you help fix it and submit a new PR?

[damywise]

@lijy91 Sorry but I currently don't have access to the Windows machine (yet again 😢 ), no idea when this time
Maybe you or @aexei can try moving the line

window_manager->title_bar_style_ != "normal"

from

window_manager/windows/window_manager_plugin.cpp

Line 115 in 36f34ea

if (wParam && message == WM_NCCALCSIZE && window_manager->title_bar_style_ != "normal") {

to

window_manager/windows/window_manager_plugin.cpp

Line 116 in 36f34ea

if (window_manager->IsFullScreen()) {

And test if it breaks anything
It probably won't break the new fullscreen implementation.

[damywise]

I finally got access to the Windows machine, need to set it up first tho. Should take at most 2-3 days.

[damywise]

@aexei Can you confirm that the linked pull request fixes this?