#148 Autoplay and stop on hover causes a warning. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 4, 2017 13:19
- Added a mouse entered state so we know when not to activate the auto play feature.
leandrowd
reviewed
Jul 4, 2017
| @@ -203,9 +204,15 @@ class Carousel extends Component { | |||
| } | |||
|
|
|||
| stopOnHover = () => { | |||
| this.setState({isMouseEntered: true}); | |||
There was a problem hiding this comment.
Can you please add test cases for these changes?
There was a problem hiding this comment.
@leandrowd I've now added tests for the isMouseEntered state change and the stop/start auto play functionality if a mouse enters/leaves.
added 2 commits
July 4, 2017 14:57
- Added build version of carousel.
- Added tests for the internal state isMouseEntered and tests for enabeling and disabeling the auto play function on mouse enter / leave.
|
Published as 3.1.24. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.