Fixes issue with initial image having unbinded event #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrowd
reviewed
Apr 23, 2017
src/components/Carousel.js
Outdated
| @@ -381,6 +384,11 @@ module.exports = React.createClass({ | |||
| ); | |||
| }, | |||
|
|
|||
| getInitialImage () { | |||
| var images = ReactDOM.findDOMNode(this.item0).getElementsByTagName('img'); | |||
| return images && images[this.props.selectedItem]; | |||
There was a problem hiding this comment.
Just realised that there is a bug in the existent code. This will only return the initial image if selectedItem is 0.
We need to change this to be:
var images = ReactDOM.findDOMNode(this['item' + this.props.selectedItem]).getElementsByTagName('img');
return images && images[0];
PradeepChada
pushed a commit
to PradeepChada/react-responsive-carousel
that referenced
this pull request
Dec 22, 2021
…03/close-icon-thickness [#180516803] - Fixed close icon thickness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #102 by removing the event listener attached to the initial image.