Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11Y div.carousel-root should accept an aria-label attribute #611

Closed
francoismassart opened this issue Jun 15, 2021 · 0 comments
Closed

A11Y div.carousel-root should accept an aria-label attribute #611

francoismassart opened this issue Jun 15, 2021 · 0 comments

Comments

@francoismassart
Copy link
Contributor

I am testing the react-responsive-carousel with Voice Over and the "root" of the gallery which has an imposed tab-index="0" (#545) does not accept any aria-label or ariaLabel attribute.

Without any custom aria-label on an interactive element, Voice Over will read ALL the readable contents from ALL the children of this interactive element. In my case, it gets really verbose, reading:

  • "previous" button text
  • every single image alt attribute
  • "next" button text
leandrowd added a commit that referenced this issue Aug 18, 2021
@leandrowd
Merge pull request #612 from francoismassart/issue/gh-611-aria-label
ba83958 
feat: add `ariaLabel` to the props, fixes #611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@francoismassart