Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility of the carousel arrows are not updated when image is loaded #104

Closed
ttamminen opened this issue Apr 21, 2017 · 1 comment
Closed

Comments

@ttamminen
Copy link
Contributor

The function updateStatics should be called when image load is ready.

Currently, the update function is called, for example, here:

        // when the component is rendered we need to calculate
        // the container size to adjust the responsive behaviour
        this.updateStatics();

But in our case images have not been loaded yet, so wrong dimensions outerWidth(this.thumb0); are being used for the calculation.

I'll create a PR with a fix.

ttamminen added a commit to ttamminen/react-responsive-carousel that referenced this issue Apr 21, 2017
leandrowd added a commit that referenced this issue Apr 23, 2017
#104 - Fixes problem where arrows were not appearing after carousel was loaded
@leandrowd
Copy link
Owner

Hi @ttamminen, thanks for you PR. All your changes are published as 3.1.7 in npm.

PradeepChada pushed a commit to PradeepChada/react-responsive-carousel that referenced this issue Dec 22, 2021
…05/swipe-again

[#180521405] - Navigation to error page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants