Support installation #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
忽然想起由于服务端的一个限制，Installation 不允许 PUT 请求，还得做一下特殊处理。 |
Contributor
Author
|
已经做了特殊处理。 |
zapcannon87
reviewed
Oct 17, 2018
|
|
||
| let name = "StorageContext" | ||
|
|
||
| var type = LocalStorageType.fileCacheOrMemory |
Contributor
There was a problem hiding this comment.
又想了一下，还是 fileCacheOrMemory 吧。
Contributor
Author
There was a problem hiding this comment.
这里我也犹豫过。我主要考虑到 API 对 installation 已经做了基于 device token 的校验和插入，用 fileCacheOrMemory 好像更合适一些。但是如果把 currentUser 也存到 storage context 里面，用 fileCacheOrMemory 好像就不太合适了，因为可能会被系统清理。
要不还是改为 filePersistent 吧？
Contributor
There was a problem hiding this comment.
依据官方的 guideline 来看，感觉 installation 的缓存属于 2 类型，放 /Library/Caches 就行；user 的缓存属于 1 类型，持久并可以被备份。
Contributor
|
LGTM |
zapcannon87
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持了 Installation 及其缓存。目前 currentInstallation 是 Application 的一个属性。
@zapcannon87