Skip to content

feat: sugar for converting number to string #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2021
Merged

feat: sugar for converting number to string #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb114bd
test: update
zapcannon87 Mar 16, 2021
a947065
feat: sugar for converting number to string
zapcannon87 Mar 16, 2021
7cb40bb
test: update
zapcannon87 Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions LeanCloud.xcodeproj/xcshareddata/xcschemes/LeanCloud.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES"
enableThreadSanitizer = "YES"
codeCoverageEnabled = "YES">
<MacroExpansion>
<BuildableReference
Expand Down Expand Up @@ -61,6 +62,7 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
enableThreadSanitizer = "YES"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
Expand Down
2 changes: 2 additions & 0 deletions LeanCloud.xcodeproj/xcshareddata/xcschemes/LeanCloudTests.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
shouldUseLaunchSchemeArgsEnv = "YES"
enableThreadSanitizer = "YES"
codeCoverageEnabled = "YES">
<AdditionalOptions>
<AdditionalOption
Expand All @@ -52,6 +53,7 @@
buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
enableThreadSanitizer = "YES"
launchStyle = "0"
useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO"
Expand Down
25 changes: 14 additions & 11 deletions LeanCloudTests/LCFileTestCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,17 +113,20 @@ class LCFileTestCase: BaseTestCase {
XCTAssertNotNil(file2.createdAt)
XCTAssertNotNil(file2.save().error)

var file3: LCFile! = LCFile(
application: application,
url: file2.url!)
XCTAssertTrue(file3.save().isSuccess)
XCTAssertNotNil(file3.mimeType)
XCTAssertNotNil(file3.name)
XCTAssertEqual(file3.metaData?.__source as? LCString, LCString("external"))
XCTAssertNotNil(file3.url)
XCTAssertNotNil(file3.objectId)
XCTAssertNotNil(file3.createdAt)
XCTAssertNotNil(file3.save().error)
var file3: LCFile!
if let file2url = file2.url {
file3 = LCFile(
application: application,
url: file2url)
XCTAssertTrue(file3.save().isSuccess)
XCTAssertNotNil(file3.mimeType)
XCTAssertNotNil(file3.name)
XCTAssertEqual(file3.metaData?.__source as? LCString, LCString("external"))
XCTAssertNotNil(file3.url)
XCTAssertNotNil(file3.objectId)
XCTAssertNotNil(file3.createdAt)
XCTAssertNotNil(file3.save().error)
}

delay()

Expand Down
21 changes: 20 additions & 1 deletion LeanCloudTests/LCTypeTestCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,5 +176,24 @@ class LCTypeTestCase: BaseTestCase {
let stringCopy = archiveThenUnarchive(string)
XCTAssertEqual(stringCopy, string)
}


func testStringValue() {
let nsNumber = NSNumber(1)
let nsString: String = nsNumber.stringValue
let lcString: String? = nsNumber.stringValue
XCTAssertEqual(nsString, lcString)

XCTAssertEqual(Int(1).stringValue, "1")
XCTAssertEqual(UInt(1).stringValue, "1")
XCTAssertEqual(Int8(1).stringValue, "1")
XCTAssertEqual(UInt8(1).stringValue, "1")
XCTAssertEqual(Int16(1).stringValue, "1")
XCTAssertEqual(UInt16(1).stringValue, "1")
XCTAssertEqual(Int32(1).stringValue, "1")
XCTAssertEqual(UInt32(1).stringValue, "1")
XCTAssertEqual(Int64(1).stringValue, "1")
XCTAssertEqual(UInt64(1).stringValue, "1")
XCTAssertEqual(Float(1).stringValue, "1.0")
XCTAssertEqual(Double(1).stringValue, "1.0")
}
}
52 changes: 52 additions & 0 deletions Sources/Foundation/Valuable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,10 @@ extension Int: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension UInt: LCNumberConvertible {
Expand All @@ -391,6 +395,10 @@ extension UInt: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension Int8: LCNumberConvertible {
Expand All @@ -401,6 +409,10 @@ extension Int8: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension UInt8: LCNumberConvertible {
Expand All @@ -411,6 +423,10 @@ extension UInt8: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension Int16: LCNumberConvertible {
Expand All @@ -421,6 +437,10 @@ extension Int16: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension UInt16: LCNumberConvertible {
Expand All @@ -431,6 +451,10 @@ extension UInt16: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension Int32: LCNumberConvertible {
Expand All @@ -441,6 +465,10 @@ extension Int32: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension UInt32: LCNumberConvertible {
Expand All @@ -451,6 +479,10 @@ extension UInt32: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension Int64: LCNumberConvertible {
Expand All @@ -461,6 +493,10 @@ extension Int64: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension UInt64: LCNumberConvertible {
Expand All @@ -471,6 +507,10 @@ extension UInt64: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension Float: LCNumberConvertible {
Expand All @@ -481,6 +521,10 @@ extension Float: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension Double: LCNumberConvertible {
Expand All @@ -491,6 +535,10 @@ extension Double: LCNumberConvertible {
public var lcNumber: LCNumber {
return LCNumber(Double(self))
}

public var stringValue: String? {
return "\(self)"
}
}

extension Bool: LCBoolConvertible {
Expand All @@ -515,6 +563,10 @@ extension NSNumber: LCNumberConvertible, LCBoolConvertible {
public var lcBool: LCBool {
return LCBool(boolValue)
}

public var stringValue: String? {
return description(withLocale: nil)
}
}

extension String: LCStringConvertible {
Expand Down