-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When evaluation done, add case which all theorem is discarded. Modify num_gpus in ray.init #24
Conversation
Thank you for the PR! Please see my comments in the code. |
Thanks, I change them! |
@irene622 The black code formatter failed. Could you please fix it ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the code format issue.
Oh, I done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thx!
Hi, I experiment your code,
I think the some of code would be good if it is changed.
After evaluation is done, in my experiment, all theorem are discarded, so I meet
ZeroDivisionError
.Hence, by using
if
, adding the case of all theorem are discarded can avoid theZeroDivisionError
.When evaluating with gpus and cpus more than 2 respectively,
ray.init
takes the argumentnum_gpus
asnum_cpus
.It cause the error in case of num gpus and num cpus are not equal.
I think it is typo, because it is easy to confuse num_cpus and num_gpus.
So, add
torch.cuda.device_count()
to find num_gpus instead of getting num_gpus as arguments.Thank you for spending your time,
I hope to merge my modification soon. :)