Skip to content

Update compatibilty with leafo/scss 0.1.* #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nicolas-brousse
Copy link

Update compass.inc.php to be compatible with the new scss compiler version.
Update also composer.json (#6) and README.md.

@@ -3,7 +3,7 @@
"description": "Compass for scssphp",
"homepage": "http://leafo.net/scssphp/",
"require": {
"leafo/scssphp": "dev-master"
"leafo/scssphp": "0.1.*"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it will be better to set the version like this: >=0.1 because scssphp-compass doesn't receive updates often.
This way it will be possible to use scssphp-compass with newer versions of scssphp even if scssphp-compass will be completely abandoned (if it's not yet).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point :)

@nicolas-brousse
Copy link
Author

composer.json file updated, thanks @artem-frolov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants