Option to connect main pic to social profile image from facebook, github or gravatar. #208
Conversation
github or gravatar. In reference to issue #206, implement an option to connect main pic to facebook, github or gravatar profile image.
|
@joariasl Please take a look at my implementation and review it. Thanks. |
|
I checked it in the code and was well. But I have this problem in my resources installed: jekyll/jemoji#57 |
|
Okay I'll take a look. |
|
@joariasl I checked the issue and couldn't find a solution to that but I think that the issue is not linked to this feature. Its an issue with the jemoji plugin which can generate irrespective of this implementation. |
|
You are right. The problem it's iwth my jiemoji installation. I can't run Jekyll for that. |
I'm hitting the same issue, and I haven't resolved it yet.. |
| @@ -11,7 +11,11 @@ <h1 class="brand-heading"> </h1> | |||
| <span class="intro-text">{{ content }}</span> | |||
| <h5> </h5> | |||
| <a href="#{{ site.pages_list['About'] }}" class="page-scroll"> | |||
| <img class="img-me" src="{{site.baseurl}}{{ site.me-img }}" alt=""> | |||
| {% if site.me-img contains "https://" %} | |||
There was a problem hiding this comment.
At first i was wondering what happens here ... but I think this is the most feasible way to check if the url is relative or absolute
|
Tested it for github and facebook - worked just fine being served locally |
|
Today i learned that i can easily rebase and merge from the UI, sorry for the delay and thanks for contributing 👍 |
|
Thanks :-) |
Connect social network profile pic.
Proposed Changes