Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide size of cursor in typed.js #141

Closed
soul-wish opened this issue Jan 17, 2016 · 6 comments
Closed

Decide size of cursor in typed.js #141

soul-wish opened this issue Jan 17, 2016 · 6 comments
Milestone

Comments

@soul-wish
Copy link
Contributor

Hi. I hope we should increase a size of typing cursor in theme's header section. Here is my solution:
Now:
screen-before
After some css fixes:
screen-after
What do you think?
PS. Also, please, check my pr regarding this issue/improvement.

@njaremko
Copy link
Contributor

The font size is fine on all my displays. Also, if you wanted to make the
text bigger, you should be using something like font-size:120% instead of
changing the font.
On Sun, Jan 17, 2016 at 7:42 AM Sergey Lysenko notifications@github.com
wrote:

Hi I hope we should increase a size of typing cursor in theme's header
section Here is my solution:
Now:
[image: screen-before]
https://camo.githubusercontent.com/d92025d187e9b0cdcc6cc3377c0e97417837541b/68747470733a2f2f636c6f756467697468756275736572636f6e74656e74636f6d2f6173736574732f313936383039382f31323337373436332f32346464343538632d626432382d313165352d383930662d316464633633646331646231706e67
After some css fixes:
[image: screen-after]
https://camo.githubusercontent.com/6276a1e6fab0da53b3c5f02feb4852b089d89bf2/68747470733a2f2f636c6f756467697468756275736572636f6e74656e74636f6d2f6173736574732f313936383039382f31323337373436372f34366630323039302d626432382d313165352d383433352d366462666362646238386265706e67
What do you think?
PS Also, please, check my pr regarding this issue/improvement


Reply to this email directly or view it on GitHub
#141.

@soul-wish
Copy link
Contributor Author

@njaremko really strange.. I checked demo site on latest Chrome, Safari, Opera and Firefox and have the same issue in all these browsers. Cursor is much smaller than quote text (typed text). I'm on OSX (maybe that is the reason). Also, I'm not sure if we should use font-size in percentage units - quote text has size in pixels - I just duplicated it for cursor (just made it a bit smaller - it looks much better in this way).

@le4ker
Copy link
Owner

le4ker commented Jan 17, 2016

I will mark it temporarily as a discussion, until I steal some time within the week (or worst case the weekend) in order to decide what we want and fix it 😉

@wvierber
Copy link

I got the cursor in small as well (Safari and Chrome on OSX).
However, in my fork of your theme, I don't have that issue. Not sure if/what I edited when I forked.

@le4ker le4ker changed the title Small design improvement Decide size of cursor in typed.js Jan 17, 2016
@soul-wish
Copy link
Contributor Author

@PanosSakkos sure! Take your time.
@wvierber you just set the same font-size for all the blocks/tags inside .intro .intro-body selector (line 214 in your grayscale.css) 😉

@Karla-Isabel-Sandoval
Copy link

The cursor is also pretty small with Chrome Version 47.0.2526.111 (64-bit).

@le4ker le4ker closed this as completed in a6822b5 Jan 30, 2016
le4ker pushed a commit that referenced this issue Jan 30, 2016
@le4ker le4ker added this to the 4.0.0 milestone Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants