Remove deprecated enum constants.

ldy810 · Apr 3, 2015 · 9d7c2d6 · 9d7c2d6
1 parent 54dbe41
commit 9d7c2d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/javascript/atoms/error.js b/javascript/atoms/error.js
@@ -46,12 +46,8 @@ bot.ErrorCode = {
   NO_SUCH_WINDOW: 23,
   INVALID_COOKIE_DOMAIN: 24,
   UNABLE_TO_SET_COOKIE: 25,
-  /** @deprecated */
-  MODAL_DIALOG_OPENED: 26,
   UNEXPECTED_ALERT_OPEN: 26,
   NO_SUCH_ALERT: 27,
-  /** @deprecated */
-  NO_MODAL_DIALOG_OPEN: 27,
   SCRIPT_TIMEOUT: 28,
   INVALID_ELEMENT_COORDINATES: 29,
   IME_NOT_AVAILABLE: 30,
@@ -176,7 +172,6 @@ goog.scope(function() {
   map[code.JAVASCRIPT_ERROR] = state.JAVASCRIPT_ERROR;
   map[code.METHOD_NOT_ALLOWED] = state.UNSUPPORTED_OPERATION;
   map[code.MOVE_TARGET_OUT_OF_BOUNDS] = state.MOVE_TARGET_OUT_OF_BOUNDS;
-  map[code.NO_MODAL_DIALOG_OPEN] = state.NO_SUCH_ALERT;
   map[code.NO_SUCH_ALERT] = state.NO_SUCH_ALERT;
   map[code.NO_SUCH_ELEMENT] = state.NO_SUCH_ELEMENT;
   map[code.NO_SUCH_FRAME] = state.NO_SUCH_FRAME;
@@ -187,7 +182,6 @@ goog.scope(function() {
   map[code.SUCCESS] = state.SUCCESS;
   map[code.TIMEOUT] = state.TIMEOUT;
   map[code.UNABLE_TO_SET_COOKIE] = state.UNABLE_TO_SET_COOKIE;
-  map[code.MODAL_DIALOG_OPENED] = state.UNEXPECTED_ALERT_OPEN;
   map[code.UNEXPECTED_ALERT_OPEN] = state.UNEXPECTED_ALERT_OPEN
   map[code.UNKNOWN_ERROR] = state.UNKNOWN_ERROR;
   map[code.UNSUPPORTED_OPERATION] = state.UNKNOWN_COMMAND;

diff --git a/javascript/node/selenium-webdriver/CHANGES.md b/javascript/node/selenium-webdriver/CHANGES.md
@@ -1,5 +1,8 @@
 ## v2.46.0-dev
 
+* Removed deprecated enum values: `ErrorCode.NO_MODAL_DIALOG_OPEN` and
+    `ErrorCode.MODAL_DIALOG_OPENED`. Use `ErrorCode.NO_SUCH_ALERT` and
+    `ErrorCode.UNEXPECTED_ALERT_OPEN`, respectively.
 * FIXED: `promise.ControlFlow#wait()` now has consistent semantics for an
     omitted or 0-timeout: it will wait indefinitely.
 * FIXED: `remote.DriverService#start()` will now fail if the child process dies
@@ -172,7 +175,7 @@ major version release (i.e. 1.0.0).
 * FIXED: 7641: Deprecated `ErrorCode.NO_MODAL_DIALOG_OPEN` and
     `ErrorCode.MODAL_DIALOG_OPENED` in favor of the new
     `ErrorCode.NO_SUCH_ALERT` and `ErrorCode.UNEXPECTED_ALERT_OPEN`,
-    respecitvely.
+    respectively.
 * FIXED: 7563: Mocha integration no longer disables timeouts. Default Mocha
     timeouts apply (2000 ms) and may be changed using `this.timeout(ms)`.
 * FIXED: 7470: Make it easier to create WebDriver instances in custom flows for