Skip to content

improve crud error messages #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cportele merged 4 commits into from
Dec 8, 2025
Merged

improve crud error messages #425

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a39a3bb
log instead of return db error messages
azahnen Dec 7, 2025
ebe4797
move mode warning to building block
azahnen Dec 7, 2025
60e8333
update mutation error message
cportele Dec 8, 2025
ffed927
Merge branch 'master' into crud-error-msgs
cportele Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions ...features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,9 +931,6 @@ public boolean supportsMutationsInternal() {
return false;
}
if (!getData().getDatasetChanges().isModeCrud()) {
LOGGER.warn(
"Feature provider with id '{}' does not support mutations: datasetChanges.mode is not 'CRUD'",
getId());
return false;
}

Expand Down Expand Up @@ -1340,10 +1337,17 @@ private MutationResult writeFeatures(
.withResult((Builder) builder)
.handleError(
(result, throwable) -> {
Throwable error =
throwable instanceof PSQLException || throwable instanceof JsonParseException
? new IllegalArgumentException(throwable.getMessage())
: throwable;
Throwable error = throwable;

if (throwable instanceof PSQLException
|| throwable instanceof JsonParseException) {
error =
new IllegalArgumentException(
"Invalid feature data. You may be able to obtain more information about the problem by adding the header ‘Prefer: handling=strict’ to the request.",
throwable);
LogContext.errorAsDebug(LOGGER, throwable, "Error during feature mutation");
}

return result.error(error);
})
.handleItem((Builder::addIds))
Expand Down