Skip to content

Commit

Permalink
disable the assertion that requires density(y|x,z) <= density(y|x) wh…
Browse files Browse the repository at this point in the history
…en using sgd since asynchrnous updates can legitimately break this assertion.
  • Loading branch information
Waleed Ammar committed Apr 3, 2015
1 parent e836ee6 commit b713d4a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/LatentCrfModel.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,7 @@ bool LatentCrfModel::ComputeNllZGivenXAndLambdaGradientPerSentence(bool ignoreTh

// update the log likelihood
sentNll -= nLogZ;
if(nLogC < nLogZ) {
if(nLogC < nLogZ && learningInfo.optimizationMethod.subOptMethod->algorithm != SGD) {
cerr << "this must be a bug. nLogC always be >= nLogZ. " << endl;
cerr << "nLogC = " << nLogC << endl;
cerr << "nLogZ = " << nLogZ << endl;
Expand Down

0 comments on commit b713d4a

Please sign in to comment.