Skip to content

Conversation

@gotmax23
Copy link
Contributor

go mod vendor only recognizes certain names for license files when including them in vendors 1. Go recognizes LICENSE but not LICENCE so this change renames the file so it can be included in vendor and projects that use vendor can comply with grignotin's license terms.

go mod vendor only recognizes certain names for license files when
including them in vendors [1]. Go recognizes LICENSE but not LICENCE so
this change renames the file so it can be included in vendor and
projects that use vendor can comply with grignotin's license terms.

[1]: https://github.com/golang/go/blob/ac94297758f3d83fca5ffa16cd179bb098bbd914/src/cmd/go/internal/modcmd/vendor.go#L398-L415
@ldez
Copy link
Owner

ldez commented Sep 17, 2025

🤔 Pragmatically, I tried it on other projects, the file LICENCE and other files like readme, YAML files, etc. are included when using go mod vendor.

So I don't understand exactly what is the problem.

@ldez
Copy link
Owner

ldez commented Sep 17, 2025

🤔 I think those files are copied only if they are inside one of imported packages (or inside a package imported by a used package) of a module.

This is as unexpected as the fact to not support UK naming.

@ldez
Copy link
Owner

ldez commented Sep 17, 2025

// ... By using this limited set of
// prefixes and also insisting on capitalized file names, we are trying
// to nudge people toward more agreement on the naming
// and also trying to avoid false positives.

What a joke... How a comment inside an internal package nudge people???

This feels like the worse approach ever to get an agreement on the naming: nobody know this rule...

There is a lot of Go projects where the license name is not capitalized and is not prefixed with LICENSE.

Sorry, it's not your fault.
I'm more than surprised by this "hidden nudge" by the Go team.

@ldez ldez changed the title Rename LICENCE to LICENSE chore: rename LICENCE to LICENSE Sep 17, 2025
@ldez ldez added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 17, 2025
@ldez ldez merged commit 448182c into ldez:main Sep 17, 2025
7 checks passed
@gotmax23
Copy link
Contributor Author

Thank you for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants