Handle numbers with digit separators, fixes tommy-muehle#8

analyzer_test.go

@@ -41,9 +41,9 @@ func TestCanExcludeNumbers(t *testing.T) {
 	testdata := analysistest.TestData()
 
 	options := flag.NewFlagSet("", flag.ExitOnError)
-	options.String("checks", "assign", "")
+	options.String("checks", "assign,argument", "")
 	options.String("excludes", "", "")
-	options.String("ignored-numbers", "100", "")
+	options.String("ignored-numbers", "1000,1234_567_890,3.14159264", "")
 
 	analyzer := Analyzer
 	analyzer.Flags = *options

config/config.go

@@ -55,7 +55,7 @@ func WithIgnoredNumbers(numbers string) Option {
 		}
 
 		for _, number := range strings.Split(numbers, ",") {
-			config.IgnoredNumbers[number] = struct{}{}
+			config.IgnoredNumbers[config.removeDigitSeparator(number)] = struct{}{}
 		}
 	}
 }
@@ -81,6 +81,10 @@ func (c *Config) IsCheckEnabled(name string) bool {
 }
 
 func (c *Config) IsIgnoredNumber(number string) bool {
-	_, ok := c.IgnoredNumbers[number]
+	_, ok := c.IgnoredNumbers[c.removeDigitSeparator(number)]
 	return ok
 }
+
+func (c *Config) removeDigitSeparator(number string) string {
+	return strings.Replace(number, "_", "", -1)
+}

testdata/src/ignored/ignored.go

@@ -1,15 +1,19 @@
 package ignored
 
 import (
+	"log"
 	"net/http"
 	"time"
 )
 
+// ignored via configuration
+var numberWithDigitSeparator int = 1_000
+
 func example() interface{} {
 	s := struct {
 		Amount int
 	}{
-		Amount: 100,
+		Amount: numberWithDigitSeparator,
 	}
 
 	return s
@@ -20,3 +24,15 @@ func example2() *http.Client {
 		Timeout: 5 * time.Second, // want "Magic number: 5"
 	}
 }
+
+func example3() {
+	// ignored via configuration
+	if int32(1234_567_890)-int32(1_234_567_890) == 0 {
+		log.Println(3.1415_9265) // want "Magic number: 3.1415_9265"
+	}
+}
+
+func example4() {
+	// ignored via configuration
+	_ = float32(3.1415_9264)
+}