Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial / start of implementation #1

Merged
merged 17 commits into from
Mar 23, 2024
Merged

Initial / start of implementation #1

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3c74338
Initial / start of implementation, already showing an odd bug
ldemailly Mar 21, 2024
676c863
fix issue with leading spaces causing 2 lines
ldemailly Mar 21, 2024
5a8c5f5
letting 132 pass
ldemailly Mar 21, 2024
82b7fe7
modify in place with backup
ldemailly Mar 21, 2024
681b48c
add *.bak to gitignore and show self run output in README
ldemailly Mar 21, 2024
b2ff7e6
forgot .goreleaser.yaml in gitignore
ldemailly Mar 21, 2024
7a35e78
adding Dockerfile
ldemailly Mar 21, 2024
b84c652
add install instructions. make gofumpt run be behind flag
ldemailly Mar 21, 2024
524d547
handle /* comments */ yet strange bug (see make test)
ldemailly Mar 21, 2024
8a700d4
added some tests
ldemailly Mar 21, 2024
0e4ce0e
gofumpt
ldemailly Mar 21, 2024
e528dcc
process all comments
ldemailly Mar 21, 2024
f195d31
process string literals that are too long as well
ldemailly Mar 21, 2024
b962d24
allow for go build .
ldemailly Mar 21, 2024
a0b8730
restore missing space in literals + test
ldemailly Mar 21, 2024
030e3a1
adding repro of newline issue
ldemailly Mar 21, 2024
b56cd66
nicer example
ldemailly Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nicer example
  • Loading branch information
@ldemailly
ldemailly committed Mar 21, 2024
commit b56cd66d995230c50ed6a79f46a93f2da6cecb6d
12 changes: 6 additions & 6 deletions bug_repro/bug.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ import (
)

/*
* multi line comment
* multi line comment.
*/
func main() {
code := `package main

/*
* multi line comment
* multi line comment.
*/
func main() {
}
`
}`
fmt.Println("---input---")
fmt.Println(code)
fmt.Println("---processing---")
Expand All @@ -30,9 +30,9 @@ func main() {
for _, cg := range node.Comments {
for _, c := range cg.List {
fmt.Printf("Found comment %q\n", c.Text)
if len(c.Text) > 10 {
if len(c.Text) > 11 {
fmt.Printf("Splitting comment %q\n", c.Text)
c.Text = c.Text[:10] + "\n * " + c.Text[10:]
c.Text = c.Text[:11] + "\n *" + c.Text[11:]
fmt.Printf("into -> %q\n", c.Text)
}
}
Expand Down
Loading