Config file: Add lib-dirs array
#2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And replace the default `-L-L<path>` LDC switches in the default config accordingly. The first advantage is for cross-compilation, where additional sections should now mostly get away with overriding `lib-dirs` (and `rpath` if need be) only; not just to specify the directory containing cross- compiled druntime and Phobos, but also further dirs containing the C libs. No need to override a whole `[post-]switches` array anymore just to tweak the lib dirs. The second advantage is that we can search these dirs for compiler-rt libs instead of being limited to `<bin dir>/../lib<LIB_SUFFIX specified in CMake command line>` or trying to guess distro-specific paths => easy-peasy for distros and users. This isn't implemented yet.
In addition (and preferred over) the previous searched-for lib dir (`<bin dir>/../lib<LIB_SUFFIX CMake var>`). [Incl. searching in some of their subdirs, e.g., `clang/x.y.z/lib/<OS>`.] I skipped that backwards-compatibility thingy for the builtins lib on Windows (not crucial, only linked (if found) on Windows etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And replace the default
-L-L<path>LDC switches in the default config accordingly.The first advantage is for cross-compilation, where additional sections should now mostly get away with overriding
lib-dirs(andrpathif need be) only; not just to specify the directory containing cross-compiled druntime and Phobos, but also further dirs containing the C libs. No need to override a whole[post-]switchesarray anymore just to tweak the lib dirs.The second advantage is that we can search these dirs for compiler-rt libs instead of being limited to
<bin dir>/../lib<LIB_SUFFIX specified in CMake command line>or trying to guess distro-specific paths => easy-peasy for distros and users.This isn't implemented yet.Edit: It is now.