Skip to content

Conversation

@kinke
Copy link
Member

@kinke kinke commented May 19, 2018

Should fix #2703.

@kinke kinke changed the title Fix compilation issues on macOS with DMD host compiler >= 2.079 Fix compilation issues on 64-bit macOS with DMD host compiler >= 2.079 May 19, 2018
@JohanEngelen
Copy link
Member

This shows how bad the mangling interop has become :( we should point the DMD folks to it.

@JohanEngelen
Copy link
Member

LGTM

@kinke
Copy link
Member Author

kinke commented May 19, 2018

This shows how bad the mangling interop has become :( we should point the DMD folks to it.

I told them ~1 month ago that size_t interop is huge. This is only the bare minimum to get LDC to link. I still count 82 occurrences of size_t in DMD's C++ headers included in LDC; not all of them would need to be replaced (struct/class fields), but most of them are function params.

@JohanEngelen
Copy link
Member

JohanEngelen commented May 19, 2018

This is the same fix This is fixing the same issue as dlang/dmd#8249, right?

@kinke
Copy link
Member Author

kinke commented May 19, 2018

Ah yeah apparently so (haven't really given that PR's changes a proper look before).

@kinke kinke merged commit e7beba6 into ldc-developers:master May 21, 2018
@kinke kinke deleted the fix2703 branch May 21, 2018 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined symbols for architecture x86_64 on MAC OS

2 participants