Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLVM 5.0 build #2173

Merged
merged 4 commits into from
Jul 2, 2017
Merged

Conversation

JohanEngelen
Copy link
Member

No description provided.

@thewilsonator
Copy link
Contributor

I'll have a new LLVM up for the SPIRV OSX box soon.

@thewilsonator
Copy link
Contributor

Done. Not sure how to force an de-chaching.

@JohanEngelen
Copy link
Member Author

Not sure how to force an de-chaching.

You could version the llvm-spirv dir (llvm-spirv-5.0.0-abc123).
You can also delete caches ("more options" top right), but then all the subbuilds will need to recache.

@dnadlinger
Copy link
Member

Yep, just version the directory name.

@thewilsonator
Copy link
Contributor

Thanks Johan. Sorry I working like mad on my honours, I'll be out of action until 5th of July.

@JohanEngelen
Copy link
Member Author

SPIRV build is green again.

driver/main.cpp Outdated
// This function exits the program.
void printVersion(llvm::raw_ostream &OS) {
OS << "LDC - the LLVM D compiler (" << global.ldc_version << "):\n";
OS << " based on DMD " << global.version << "and LLVM " << global.llvm_version << "\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before and LLVM.

@JohanEngelen
Copy link
Member Author

:( travis jobs keep running out of time

@kinke
Copy link
Member

kinke commented Jun 25, 2017

Yeah on weekends the Travis performance is a catastrophe. :/

@JohanEngelen
Copy link
Member Author

It looks like we really need to find an alternative to Travis, or speed up our builds by a lot :(
I'm tired of not being able to merge things because of Travis issues :/

@wilzbach
Copy link
Contributor

wilzbach commented Jul 1, 2017

I'm tired of not being able to merge things because of Travis issues :/

Not that it would help with the timeouts on Travis, but I am happy to setup auto-merge with the Dlang-Bot in case that would help you. Currently it doesn't restart failing transient Travis builds yet, but that is on our TODO list (of course it will happen faster with a PR).

@kinke
Copy link
Member

kinke commented Jul 2, 2017

Rebased after merging the Travis & dmd-testsuite tweaks in #2074. Travis time-outs should now be exceedingly rare. Circle a) relies on the flaky LLVM APT repo and b) currently exhibits a new/temporary (?) failure of runnable/gdb4149.d; let's hope the rest is finally green now again (without having to retrigger Travis jobs manually).

@thewilsonator
Copy link
Contributor

Circle has had that GDB failure for quite some time (months), unless it got fixed and its a new failure.

@JohanEngelen JohanEngelen merged commit fdd66e5 into ldc-developers:master Jul 2, 2017
@JohanEngelen JohanEngelen deleted the llvm5fix branch July 2, 2017 09:35
@kinke kinke mentioned this pull request Jul 2, 2017
6 tasks
kinke pushed a commit that referenced this pull request Jul 6, 2017
* Fix LLVM 5.0 compilation.

* Fix adding linker option metadata to LLVM module.

See https://reviews.llvm.org/D31349

* Version the SPIRV cache dir on travis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants