Use LLVM headers for shared codegen command-line options #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
changed the title
kinke
force-pushed
the
cgoptions
branch
2 times, most recently
from
b2eb329 to
bc058b5
Compare
|
The plan is to later copy the LLD wrappers into this .cpp module and hoping that the linker will use these ones for LLD instead of dragging in the LLD object (with conflicting command-line options). This approach should be scalable for other LLVM components including these shared headers. Edit: If this works, it'll require LLD 5.0 due to the details here. :/ |
kinke
commented
Jun 3, 2017
driver/cl_options.cpp
Outdated
| "use-ctors", "use-init-array", "emulated-tls", "unique-section-names", | ||
| "jump-table-type", "meabi", "debugger-tune", "asm-instrumentation", | ||
| "mc-relax-all", "incremental-linker-compatible", "asm-show-inst", "fcfi", | ||
| "cfi-type", "cfi-enforcing", "cfi-func-name", "pie-copy-relocations", |
There was a problem hiding this comment.
That's the most interesting part, the new hidden options, incl. some fine-grained FP math options.
Edit: They are also version specific, e.g., the 4 -*cfi* options are exclusively exposed by LLVM 3.6.
kinke
force-pushed
the
cgoptions
branch
3 times, most recently
from
6b3afd1 to
7a538aa
Compare
kinke
changed the title
kinke
changed the title
This was referenced Aug 16, 2017
Merged
Merged
kinke
added a commit
to kinke/ldc
that referenced
this pull request
Sep 9, 2017
And allow CMake variable LDC_WITH_LLD to be specified on the command line. LLD 5.0+ needs ldc-developers#2148 to avoid conflicting command-line options.
kinke
added a commit
to kinke/ldc
that referenced
this pull request
Sep 9, 2017
And allow CMake variable LDC_WITH_LLD to be specified on the command line. LLD 5.0+ needs ldc-developers#2148 to avoid conflicting command-line options.
|
Good to go now? |
|
Dammit, |
I.e., llvm/CodeGen/CommandFlags.h which in turn includes llvm/MC/MCTargetOptionsCommandFlags.h. This gets rid of a few duplicates on our side and includes about 35 (depending on LLVM version) new command-line options. LLVM provides a helper function to set up the TargetOptions according to (most of) these options. Newer LLVM versions may add new options and we'll automatically inherit them, including setting up the TargetOptions accordingly. I did my best (TM) to remove a few unused/undesirable options and hide all remaining new ones except for `-fp-contract`. The lists will need to be tweaked from time to time.
|
It's a big change, and I did not do a very detailed review. It looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e., llvm/CodeGen/CommandFlags.h which in turn includes llvm/MC/MCTargetOptionsCommandFlags.h.
This gets rid of a few duplicates on our side and includes about 35 (depending on LLVM version) new command-line options. LLVM provides a helper function to set up the TargetOptions according to (most of) these options.
Newer LLVM versions may add new options and we'll automatically inherit them, including setting up the TargetOptions accordingly.
I did my best (TM) to remove a few unused/undesirable options and hide all remaining new ones except for
-fp-contract. The lists will need to be tweaked from time to time.