Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime is not automatically built before installation, but make install fails without it being present #19

Closed
dnadlinger opened this issue Nov 12, 2011 · 6 comments

Comments

@dnadlinger
Copy link
Member

If I don't manually build the runtime before installing, this happens:

$ make install
[  0%] Built target idgen
[  0%] Built target impcnvgen
[100%] Built target ldc2
Install the project...
-- Install configuration: ""
-- Installing: /usr/local/bin/ldc2
-- Up-to-date: /usr/local/bin/ldmd2
-- Installing: /usr/local/etc/ldc2.conf
-- Installing: /usr/local/etc/ldc2.rebuild.conf
CMake Error at cmake_install.cmake:63 (FILE):
  file INSTALL cannot find "/Build/Work/ldc2/runtime/import/core".

This is not quite optimal from an usability point of view. As far as I know, installation dependencies for CMake are so easy to specify – is there any reason not to build the runtime as part of the default make target? @bioinfornatics?

@bioinfornatics
Copy link
Contributor

runtime build is define by runtime/CmakeList.txt file so for this reason i think is not on default target. But this it exist before i had do any change

@dnadlinger
Copy link
Member Author

Being in a subdirectory is not the reason for it being not part of the ALL target, but because EXCLUDE_FROM_ALL has been explicitly specified for the add_subdirectory some three years ago. I'm changing it to be built by default so that installation goes smooth – if somebody wants to build only the compiler for some reason, they can always use the ldc2 target.

@bioinfornatics
Copy link
Contributor

great :-)
They are only one reason for build only the compiler: if you want use as D1 with tango

@dnadlinger
Copy link
Member Author

You would use D_VERSION=1 then anyway, which isn't affected by the change.

@bioinfornatics
Copy link
Contributor

for me is good

@dnadlinger
Copy link
Member Author

Fixed in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants