Output validation using matching in SQL#217
Merged
Merged
Conversation
df28286 to
1407616
Compare
929a105 to
57c4366
Compare
243bf48 to
f4acf27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will fix #205.
We can use the DuckDB appender to populate the tables.
Current validation scripts are in:
A lot of time is spent parsing the results back from CSVs to Java data structures, this could also be improved by using DuckDB's
COPY ... FROM 'filename.csv' (DELIMITER ' ', FORMAT csv)clause.Validation tests (that are used to test the validation rules themselves) are in:
Populating tables using the DuckDB appender and comparing WCC results
A snippet for using appenders (not sure whether it is useful):
Handling infinity values
Handling infinity necessitates special care as multiple values should be accepted:
Validation of completeness
The validation should not only check whether the results are correct, it should also check whether all vertices are included in the result set.